-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cleanup and complete body and subbody types lists #325
fix: cleanup and complete body and subbody types lists #325
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 39.91% 41.33% +1.42%
==========================================
Files 84 84
Lines 7611 7806 +195
==========================================
+ Hits 3038 3227 +189
- Misses 4573 4579 +6 ☔ View full report in Codecov by Sentry. |
@rokam when you have a couple of spare minutes, please install the app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound great. Just don't remove the current enums. Let's deprecated first to avoid breaking change.
Co-authored-by: Lucas Mindêllo de Andrade <lucas@mindello.com.br>
Co-authored-by: Lucas Mindêllo de Andrade <lucas@mindello.com.br>
e146ae8
to
1479689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤖 I have created a release *beep* *boop* --- ## [6.0.3](v6.0.2...v6.0.3) (2024-10-15) ### Bug Fixes * cleanup and complete body and subbody types lists ([#325](#325)) ([914dcb8](914dcb8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
cc @wuwentao